Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't error out on non-existent optional peer dependency #69

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix: Don't error out on non-existent optional peer dependency #69

merged 2 commits into from
Sep 23, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit mentioned this pull request Sep 17, 2024
Closed
littledivy
littledivy reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should print a warning?

@nathanwhit
Copy link
Member Author

Maybe we should print a warning?

I thought about it, but NPM doesn't and I think it wouldn't be super useful to users. It would mean that pretty much anyone using https://www.npmjs.com/package/crossws would get a warning (that they couldn't actually do anything about)

@littledivy
Copy link
Member

Ah okay sgtm

marvinhagemeister
marvinhagemeister approved these changes Sep 23, 2024
View reviewed changes
Copy link

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit merged commit 5cecfe9 into denoland:main Sep 23, 2024
1 check passed
@nathanwhit nathanwhit deleted the optional-peer-deps branch September 23, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathanwhit @littledivy @marvinhagemeister @bartlomieju